[webkit-reviews] review granted: [Bug 37053] WorkerGlobalScope.close() should let the currently running script complete execution, then terminate the worker. : [Attachment 52909] Patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Dmitry Titov <dimich at chromium.org>'s
request for review:
Bug 37053: WorkerGlobalScope.close() should let the currently running script
complete execution, then terminate the worker.
https://bugs.webkit.org/show_bug.cgi?id=37053

Attachment 52909: Patch.
https://bugs.webkit.org/attachment.cgi?id=52909&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   return new CloseWorkerContextTask();

I normally leave out the parentheses in new expressions like this one.

> -    // Notify parent that this context is closed. Parent is responsible for
calling WorkerThread::stop().
> -    thread()->workerReportingProxy().workerContextClosed();
> +    // Let current script run to completion	but prevent future script
evaluations.

Extra space here before "but".

While I don't understand every bit of the patch thoroughly, it looks good to
me, and the tests seem to cover what's changing here. r=me