[webkit-reviews] review granted: [Bug 37275] Accessibility support for progress element : [Attachment 52890] Patch to addres review comments.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 37275: Accessibility support for progress element
https://bugs.webkit.org/show_bug.cgi?id=37275

Attachment 52890: Patch to addres review comments.
https://bugs.webkit.org/attachment.cgi?id=52890&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +class AccessibilityProgressIndicator : public AccessibilityRenderObject {
> +    
> +public:
> +    static PassRefPtr<AccessibilityProgressIndicator> create(RenderObject*);

> +
> +private:
> +    virtual AccessibilityRole roleValue() const { return
ProgressIndicatorRole; }
> +
> +    virtual bool isProgressIndicator() const { return true; }
> +
> +    virtual float valueForRange() const;
> +    virtual float maxValueForRange() const;
> +    virtual float minValueForRange() const;
> +
> +    AccessibilityProgressIndicator(RenderObject*);
> +
> +private:
> +    HTMLProgressElement* element() const;
> +    virtual bool accessibilityIsIgnored() const;
> +};

Extra blank line before public here. The argument type should be
RenderProgress* rather than RenderObject* to make it clear it's illegal to call
this with another kind of RenderObject. No need to say "private" twice. r=me