[webkit-reviews] review denied: [Bug 37228] Allow white listing access from origin to local origin : [Attachment 52774] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 37228: Allow white listing access from origin to local origin
https://bugs.webkit.org/show_bug.cgi?id=37228

Attachment 52774: Patch
https://bugs.webkit.org/attachment.cgi?id=52774&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I like the approach.  Two comments:

 301	     if (OriginAccessWhiteList* list =
originAccessMap().get(documentOrigin->toString())) {
 302		 PassRefPtr<SecurityOrigin> targetOrigin =
SecurityOrigin::create(url);
 303		 for (size_t i = 0; i < list->size();  ++i) {
 304		     if (list->at(i).matchesOrigin(*targetOrigin))
 305			 return true;
 306		 }
 307	     }

This looks like copy/paste code.  Can we abstract that into a private method?

+var localImageLocation =
layoutTestController.pathToLocalResource('file:///tmp/LayoutTests/http/tests/se
curity/resources/compass.jpg');

Will this file URL work on all platforms (e.g., Windows)?  Is this how other
tests do this?