[webkit-reviews] review denied: [Bug 37098] fast/canvas/webgl/drawArraysOutOfBounds.html failed on Leopard Commit Bot : [Attachment 52770] revised patch: fixed a typo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 7 13:23:33 PDT 2010


Eric Seidel <eric at webkit.org> has denied Zhenyao Mo <zmo at google.com>'s request
for review:
Bug 37098: fast/canvas/webgl/drawArraysOutOfBounds.html failed on Leopard
Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=37098

Attachment 52770: revised patch: fixed a typo
https://bugs.webkit.org/attachment.cgi?id=52770&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The JS change need a FIXME comment next to it with a link to one of these bugs.


Also, why not just do if (!attrs) instead of checking for typeof == undefined?


More information about the webkit-reviews mailing list