[webkit-reviews] review denied: [Bug 36949] Web Inspector: remove inspector methods from ScriptExecutionContext and derived classes : [Attachment 52411] Remove inspector methods from ScriptExecutionContext & dervied classes. Remove MessageDestination parameter from console message calls. Remove logging upon successful XHR & importScripts (style fixed)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 08:40:19 PDT 2010


Adam Barth <abarth at webkit.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 36949: Web Inspector: remove inspector methods from ScriptExecutionContext
and derived classes
https://bugs.webkit.org/show_bug.cgi?id=36949

Attachment 52411: Remove inspector methods from ScriptExecutionContext &
dervied classes. Remove MessageDestination parameter from console message
calls. Remove logging upon successful XHR & importScripts (style fixed)
https://bugs.webkit.org/attachment.cgi?id=52411&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch looks great.  I'm really happy we're going to stop spamming the
console with XHR finished messages.

I'm surprised this didn't change the expected results of any LayoutTests.  I'd
imagine that any test that used XHR would have its expected output changed. 
Are you sure you ran all the tests?

Please separate this change into two patches:
1) Removing the console spam.
2) Removing all the dead code.

Thanks for the patch.


More information about the webkit-reviews mailing list