[webkit-reviews] review denied: [Bug 37008] ScriptController::processingUserGestureEvent returns true for simulated clicks : [Attachment 52388] patch (v2)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 08:31:20 PDT 2010


Adam Barth <abarth at webkit.org> has denied Andy Estes <aestes at apple.com>'s
request for review:
Bug 37008: ScriptController::processingUserGestureEvent returns true for
simulated clicks
https://bugs.webkit.org/show_bug.cgi?id=37008

Attachment 52388: patch (v2)
https://bugs.webkit.org/attachment.cgi?id=52388&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This is great.	I've wanted to do this for a while but hadn't gotten around to
it.

Some nits:

+ createdByDOM

I think you can remove this concept now.

+ NonHeapAllocatable.h

You've add this header to the xcodeproj but not to the other build systems. 
Please add it to all the build systems (except the "pro", which doesn't include
headers).

As for whether this is fixed, we have more popup blocker bypasses that this
either will fix or give us the tools to fix.


More information about the webkit-reviews mailing list