[webkit-reviews] review granted: [Bug 36802] setting document.title doesn't change document.title value : [Attachment 52283] v3; fix changelog wording a litle

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 16:39:05 PDT 2010


Darin Adler <darin at apple.com> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 36802: setting document.title doesn't change document.title value
https://bugs.webkit.org/show_bug.cgi?id=36802

Attachment 52283: v3; fix changelog wording a litle
https://bugs.webkit.org/attachment.cgi?id=52283&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   // We make a copy here because entity of "value" argument can be
Document::m_title,
> +	   // which goes empty during removeChildren() invocation below,
> +	   // which causes HTMLTitleElement::childrenChanged(), which ends up
Document::setTitle().

"ends up Document::setTitle" should be "ends up calling Document::setTitle".

r=me


More information about the webkit-reviews mailing list