[webkit-reviews] review granted: [Bug 31680] WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer : [Attachment 52279] v5; took the feedback to respect compatibiity

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 31680: WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer
https://bugs.webkit.org/show_bug.cgi?id=31680

Attachment 52279: v5; took the feedback to respect compatibiity
https://bugs.webkit.org/attachment.cgi?id=52279&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    if (!n || selection->isNone())
> +    if (!n || m_frame->document() != n->document() || selection->isNone())
>	   return false;

Why did you choose not to use your isValidForPosition helper function here?

> +bool DOMSelection::isValidForPosition(Node* node) const
> +{
> +    ASSERT(m_frame);
> +    if (!node)
> +	   return true;
> +    return (node->document() == m_frame->document());
> +}

Extra parentheses here.

r=me

Lets send the feedback to the HTML5 folks about not the need to not raise
exceptions in these cases for compatibility.