[webkit-reviews] review granted: [Bug 36980] Add object addresses to debug showLayerTree() output. : [Attachment 52334] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 1 16:16:38 PDT 2010


Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 36980: Add object addresses to debug showLayerTree() output.
https://bugs.webkit.org/show_bug.cgi?id=36980

Attachment 52334: Patch
https://bugs.webkit.org/attachment.cgi?id=52334&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (behavior & RenderAsTextShowAddresses)
> +	   ts << " " << static_cast<const void*>(&o);

What happens if you don't do the static_cast? Does it fail to compile? Can you
leave the cast out?

r=me


More information about the webkit-reviews mailing list