[webkit-reviews] review denied: [Bug 30954] Possible race condition in Database.cpp : [Attachment 52234] patch: put m_stopped behind a lock
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 1 16:05:22 PDT 2010
David Levin <levin at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 30954: Possible race condition in Database.cpp
https://bugs.webkit.org/show_bug.cgi?id=30954
Attachment 52234: patch: put m_stopped behind a lock
https://bugs.webkit.org/attachment.cgi?id=52234&action=review
------- Additional Comments from David Levin <levin at chromium.org>
It seems to have been noted by other folks that this doesn't really solve
anything except to make an arbitrary tool happy by slowing things down and
using more memory.
If there is some core issue, then this definitely doesn't fix it. If there
isn't an issue, then there perhaps there should be a comment in the code to
explain why this is ok.
More information about the webkit-reviews
mailing list