[webkit-reviews] review denied: [Bug 29910] Load state can get out of sync in a client callback, leading to a crash. : [Attachment 40339] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 29910: Load state can get out of sync in a client callback, leading to a
crash.
https://bugs.webkit.org/show_bug.cgi?id=29910

Attachment 40339: Patch
https://bugs.webkit.org/attachment.cgi?id=40339&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
r- because:
1 - I'm not exactly clear what the motivation for the change is
2 - The change is only partial (this pattern appears more than once)
3 - We *NEED* to start enforcing layouttests for loader changes like these.


Elaborations:
1 - Before we jump the gun on this change, I'd like some more details of what
the problem actually is.  Your description of the bug sounds theoretical -
could you post a crash log and steps to reproduce?
2 - This pattern of setting FrameStateComplete after the progressCompleted()
callback occurs more than once, and appears to have been a deliberate decision.
 While I have no direct evidence it's the wrong change, my Spidey Sense is
tingling.
3 - If we clear up #1 and #2, I'm sure I can help find a way to layouttest
this.