[webkit-reviews] review denied: [Bug 29656] Make WebKitTools/Scripits/run-sunspider script work on Windows platform : [Attachment 40365] updated patch

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Csaba Osztrogonác
<oszi at inf.u-szeged.hu>'s request for review:
Bug 29656: Make WebKitTools/Scripits/run-sunspider script work on Windows
platform
https://bugs.webkit.org/show_bug.cgi?id=29656

Attachment 40365: updated patch
https://bugs.webkit.org/attachment.cgi?id=40365&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> diff --git a/WebKitTools/Scripts/webkitdirs.pm
b/WebKitTools/Scripts/webkitdirs.pm
>  # used for scripts which are stored in a non-standard location
> +sub currentPerlPath()
> +{
> +    return $^X;
> +}

I really think you should use the method from Comment #8 due to the reasons I
outlined in Comment #11:  it's guaranteed to work, and we don't know exactly
which platforms it's needed on.

r-