[webkit-reviews] review granted: [Bug 28941] Add webSocketEnabled flag in Settings : [Attachment 40226] rename webSocketsEnabled to experimentalWebSocketEnabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 28 11:40:06 PDT 2009


Eric Seidel <eric at webkit.org> has granted Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 28941: Add webSocketEnabled flag in Settings
https://bugs.webkit.org/show_bug.cgi?id=28941

Attachment 40226: rename webSocketsEnabled to experimentalWebSocketEnabled
https://bugs.webkit.org/attachment.cgi?id=40226&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I dont' think the explicit resetDefaultsToConsistentValues reset calls are
really necessary, but they're certainly not a bad idea either.

LGTM.  If you want this auto-committed, you'll need to set cq? as well.  I
can't remember if you're a committer yet or not.


More information about the webkit-reviews mailing list