[webkit-reviews] review granted: [Bug 28054] use derefInNotNull function to work around winscw compiler bug regarding template arguments. : [Attachment 40239] remove the Tab in previous patch, please review, thanks.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 28 11:37:43 PDT 2009


Eric Seidel <eric at webkit.org> has granted Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 28054: use derefInNotNull function to work around winscw compiler bug
regarding template arguments.
https://bugs.webkit.org/show_bug.cgi?id=28054

Attachment 40239: remove the Tab in previous patch, please review, thanks.
https://bugs.webkit.org/attachment.cgi?id=40239&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
svn-create-patch should certainly at least warn about tabs.  (bug 29509) 
Having a --remove-tabs option wouldn't necessarily be bad either.


More information about the webkit-reviews mailing list