[webkit-reviews] review denied: [Bug 20081] [Qt] Add support for windowless NPAPI plugins : [Attachment 40216] Windowless patch - makes painting work (3)

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Girish Ramakrishnan
<girish at forwardbias.in>'s request for review:
Bug 20081: [Qt] Add support for windowless NPAPI plugins
https://bugs.webkit.org/show_bug.cgi?id=20081

Attachment 40216: Windowless patch - makes painting work (3)
https://bugs.webkit.org/attachment.cgi?id=40216&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
This is a great start!

After a quick discussion with Girish on IRC we agreed that makes more sense to
fix point 4/5 and 6 in the TODO before landing. Otherwise I don't see any
issues with the existing patch, except that it would be good to replace the
unconditional enabling of the supportswindowless variable with something
slightly more conditional depending on the availability of the backing store
for example.