[webkit-reviews] review granted: [Bug 28902] Windows DumpRenderTree should properly set the drop effect for a drag-and-drop operation : [Attachment 40213] Patch

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 28902: Windows DumpRenderTree should properly set the drop effect for a
drag-and-drop operation
https://bugs.webkit.org/show_bug.cgi?id=28902

Attachment 40213: Patch
https://bugs.webkit.org/attachment.cgi?id=40213&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   * DumpRenderTree/win/DraggingInfo.h: Added field |m_dropEffect| to
store performed drop effect.

I haven't seen this "|variableName|" style in ChangeLogs/comments in WebKit
before. I'm not saying I'm opposed, just pointing out that you're going against
the grain here.

r=me