[webkit-reviews] review requested: [Bug 27029] [Qt] Allow custom memory allocation control in the whole JSCore : [Attachment 40066] updated proposed patch

[bugzilla-daemon at webkit.org]

Zoltan Horvath <zoltan at webkit.org> has asked  for review:
Bug 27029: [Qt] Allow custom memory allocation control in the whole JSCore
https://bugs.webkit.org/show_bug.cgi?id=27029

Attachment 40066: updated proposed patch
https://bugs.webkit.org/attachment.cgi?id=40066&action=review

------- Additional Comments from Zoltan Horvath <zoltan at webkit.org>

> Why does this not just blow out the stack?

It follows the implementation of the windows version:

#if PLATFORM(WIN)
static void sleep(unsigned seconds)
{
    ::Sleep(seconds * 1000);
}
#endif

> Is one of them in WTF?  If so, then the other should use :: to make it
explicit
> that it's a root namespace call.

No it isn't. I put :: in.

> Also the sleep call seems unrelated to the rest of the patch, or at least is
> not explained in the ChangeLog.

> diff likes newlines at end of files:
> +DEFINES+=USE_SYSTEM_MALLOC
> \ No newline at end of file
> (so does GCC)

Done.