[webkit-reviews] review granted: [Bug 28689] Replace disabled media mute button with port-specific implementation. : [Attachment 40027] Third attempt

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Andrew Scherkus
<scherkus at chromium.org>'s request for review:
Bug 28689: Replace disabled media mute button with port-specific
implementation.
https://bugs.webkit.org/show_bug.cgi?id=28689

Attachment 40027: Third attempt
https://bugs.webkit.org/attachment.cgi?id=40027&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> -    return HTMLDivElement::rendererIsNeeded(style) && parent() &&
parent()->renderer();
> +    return HTMLDivElement::rendererIsNeeded(style) && parent() &&
parent()->renderer()
> +	   &&
document()->page()->theme()->shouldRenderMediaControlPart(style->appearance(),
m_mediaElement);

I don't know if the page can ever be NULL in this situation, but it is probably
worth adding a check since RenderObject::theme() asserts it.

> -    return HTMLInputElement::rendererIsNeeded(style) && parent() &&
parent()->renderer();
> +    return HTMLInputElement::rendererIsNeeded(style) && parent() &&
parent()->renderer()
> +	   &&
document()->page()->theme()->shouldRenderMediaControlPart(style->appearance(),
m_mediaElement);

Ditto.

r=me with this change.