[webkit-reviews] review granted: [Bug 29031] [v8] speed up access to windows impl from various methods : [Attachment 39853] Second iteration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 23 14:18:08 PDT 2009


Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 29031: [v8] speed up access to windows impl from various methods
https://bugs.webkit.org/show_bug.cgi?id=29031

Attachment 39853: Second iteration
https://bugs.webkit.org/attachment.cgi?id=39853&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  Much easier to understand than the last round.  One
question:

+namespace v8 {
+Handle<Value> GetRealNamedProperty(
+      Handle<Object> object,
+      Handle<String> key);
+}

Shouldn't this be in a v8 header file?	As written, it looks like it's grabbing
at some random symbol in V8.


More information about the webkit-reviews mailing list