[webkit-reviews] review granted: [Bug 29694] WebCore side of changes to remove gfx::Rect dependency from ImageSkia : [Attachment 40016] patch v1

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 29694: WebCore side of changes to remove gfx::Rect dependency from
ImageSkia
https://bugs.webkit.org/show_bug.cgi?id=29694

Attachment 40016: patch v1
https://bugs.webkit.org/attachment.cgi?id=40016&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me, with nits:

> +	   https://bugs.webkit.org/show_bug.cgi?id=29694
> +	   Eliminate dependency on gfx::Rect from ImageSkia.

pls put [Chromium] in front of the description.

> -    SkIRect resizedImageRect;  // Represents the size of the resized image.
> -    resizedImageRect.set(0, 0, destRectRounded.width(),
destRectRounded.height());
> +    SkIRect resizedImageRect =  // Represents the size of the resized image.

> +	   { 0, 0, destRectRounded.width(), destRectRounded.height() };

This looks a bit weird, but ok.