[webkit-reviews] review granted: [Bug 29652] RenderThemeChromiumWin should use true system colors for CSS system colors : [Attachment 39944] patch v1

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 29652: RenderThemeChromiumWin should use true system colors for CSS system
colors
https://bugs.webkit.org/show_bug.cgi?id=29652

Attachment 39944: patch v1
https://bugs.webkit.org/attachment.cgi?id=39944&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Two minor nits to fix up on landing.

> Index: WebCore/rendering/RenderThemeChromiumWin.cpp
> ===================================================================
> +// Map a CSSValue* system color to an index understood by GetSysColor

Please add a period to the end of the sentence.

> +static int cssValueIdToSysColorIndex(int cssValueId)
> +{
> +    switch (cssValueId) {
> +	   case CSSValueActiveborder: return COLOR_ACTIVEBORDER;

A case label should line up with its switch statement (see
http://webkit.org/coding/coding-style.html)