[webkit-reviews] review denied: [Bug 29246] [Qt] State of navigation buttons aren't updated : [Attachment 39548] Proposed path
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 22 14:36:50 PDT 2009
Eric Seidel <eric at webkit.org> has denied jedrzej.nowacki at nokia.com's request
for review:
Bug 29246: [Qt] State of navigation buttons aren't updated
https://bugs.webkit.org/show_bug.cgi?id=29246
Attachment 39548: Proposed path
https://bugs.webkit.org/attachment.cgi?id=39548&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
//update navi buttons
Comments should be proper english sentences, starting with a capital ending
with a period.
Also, I believe the style guide asks for a space after the //.
Regarding the rest of the change, I have no comment. Although ideally it
should have a test if that's possible, or an explanation in the ChangeLog of
why a test is impossible/impractical.
More information about the webkit-reviews
mailing list