[webkit-reviews] review requested: [Bug 26342] Absolutely positioned HTML element within foreignObject of absolutely positioned SVG crashes Safari : [Attachment 39844] re-submission
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 21 02:42:32 PDT 2009
Charles Wei <charles.wei at torchmobile.com.cn> has asked for review:
Bug 26342: Absolutely positioned HTML element within foreignObject of
absolutely positioned SVG crashes Safari
https://bugs.webkit.org/show_bug.cgi?id=26342
Attachment 39844: re-submission
https://bugs.webkit.org/attachment.cgi?id=39844&action=review
------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
re-submission of the patch .
1. This patch focuses on the crash of the webkit, simpifying the original
"while" statement raised by Eric is not in the scope of this bug. I would
rather leave that alone as is, you can have a separate bug to track that
change .
2. o->node()->hasTagName(SVGNames::foreignObjectTag) replaced by
RenderObject::isSVGForeignObject(), as suggested by Eric
3. Test case as a dumpAsText() , following Eric's suggestion .
More information about the webkit-reviews
mailing list