[webkit-reviews] review requested: [Bug 14566] Changing document.domain does not raise javascript exception : [Attachment 39843] Patch to raise SECURITY_ERR exception if an attempt is made to change document.domain to an invalid value ("document.domain" is not set to "mydummydomain" any more in fast/forms/basic-textareas.html)

[bugzilla-daemon at webkit.org]

Yuan Song <song.yuan at ericsson.com> has asked  for review:
Bug 14566: Changing document.domain does not raise javascript exception
https://bugs.webkit.org/show_bug.cgi?id=14566

Attachment 39843: Patch to raise SECURITY_ERR exception if an attempt is made
to change document.domain to an invalid value ("document.domain" is not set to
"mydummydomain" any more in fast/forms/basic-textareas.html)
https://bugs.webkit.org/attachment.cgi?id=39843&action=review

------- Additional Comments from Yuan Song <song.yuan at ericsson.com>
In this new patch, "document.domain" is not set to "mydummydomain" any more in
fast/forms/basic-textareas.html. It looks to me that it's faulty and not
necessary. Because "document.domain" is set to "layouttests" if a local html
file is launched by DumpRenderTree, so the access to the iframe is allowed
anyway. Running this modified basic-textarea.html in DumpRenderTree gives
exactly the same output as the original one. The test is conducted in WebKit
gtk port in Ubuntu. I'm now trying to borrow a Mac to verify it.