[webkit-reviews] review denied: [Bug 29092] Performance slow when loading a large text html file on Symbian platform : [Attachment 39646] patch with modified description

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 29092: Performance slow when loading a large text html file on Symbian
platform
https://bugs.webkit.org/show_bug.cgi?id=29092

Attachment 39646: patch with modified description
https://bugs.webkit.org/attachment.cgi?id=39646&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	 Optimize the code so only the text from start to end is scaned.

Typo: should be "scanned".

+    if(end < dataLength) {

Please add a space after "if".

+	 TextBreakIterator* it = characterBreakIterator(data.characters() +
start, end - start + 1);

How will this behave if a non-BMP character is coming next (one that takes two
UTF-16 values)? Depending on the platform implementation of the iterator, it
may not work well.

Seems that this needs at least "+ 2". I think that it would work then, but I'm
also not 100% sure.

>     // If we have maxChars of unbreakable characters the above could lead to
>     // an infinite loop.

This comment needs to be updated, now that we rely on the code below in more
cases.

What exactly gave the performance boost for Qt, trimming from the beginning, or
from the end? If the latter is not necessary, I suggest passing the entire
remainder of the text to iterator.