[webkit-reviews] review denied: [Bug 29502] basic inputs layout test for chromium : [Attachment 39787] basic inputs layout test patch - fixed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 18 14:00:47 PDT 2009


Eric Seidel <eric at webkit.org> has denied Karen <karen+webkit at chromium.org>'s
request for review:
Bug 29502: basic inputs layout test for chromium
https://bugs.webkit.org/show_bug.cgi?id=29502

Attachment 39787: basic inputs layout test patch - fixed patch.
https://bugs.webkit.org/attachment.cgi?id=39787&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The tab in the ChangeLog will make this unlandable.  (We have a pre-commit hook
which rejects commits with tabs in them.)

The ChangeLog shoudl also explain more what you're doing here.	Why this test,
and what does it test that other tests don't?


More information about the webkit-reviews mailing list