[webkit-reviews] review requested: [Bug 29126] Play/pause button in <video> controls shows the wrong image : [Attachment 39351] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 10 08:44:07 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has asked  for review:
Bug 29126: Play/pause button in <video> controls shows the wrong image
https://bugs.webkit.org/show_bug.cgi?id=29126

Attachment 39351: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39351&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
The play/pause button in <video> controls currently shows the "play" image when
the video is playing, and the "pause" image when the video is paused. But in
most media players (and <video> controls on Mac), the button image reflects
what the button will do, not the current state of the video.

To reproduce:

1. Go to
http://movies.apple.com/datapub/us/podcasts/apple_keynotes/sept2009_event.m4v

When the movie starts playing, the play/pause button shows a "play" image. If
you u click it, it will show a "pause" button. This is backwards!


More information about the webkit-reviews mailing list