[webkit-reviews] review granted: [Bug 29126] Play/pause button in <video> controls shows the wrong image : [Attachment 39351] Patch v1

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 29126: Play/pause button in <video> controls shows the wrong image
https://bugs.webkit.org/show_bug.cgi?id=29126

Attachment 39351: Patch v1
https://bugs.webkit.org/attachment.cgi?id=39351&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> +	   No test possible.

The existing pixel tests will check this as a side effect - once you update the
results ;-)


> -		   bool currentlyPlaying = btn->displayType() ==
MediaPlayButton;
> -		   paintThemePart(currentlyPlaying ?
SafariTheme::MediaPauseButtonPart : SafariTheme::MediaPlayButtonPart,
paintInfo.context->platformContext(), r, NSRegularControlSize,
determineState(o));
> +		   bool canPlay = btn->displayType() == MediaPlayButton;
> +		   paintThemePart(canPlay ? SafariTheme::MediaPlayButtonPart :
SafariTheme::MediaPauseButtonPart, paintInfo.context->platformContext(), r,
NSRegularControlSize, determineState(o));

"canPlay" can be slightly misleading because the movie may not have enough
media buffered to begin playback immediately, but I may be too pedantic.

r=me if you update the pixel test results at some point.