[webkit-reviews] review denied: [Bug 28882] Merge chromium's config.h.in into WebCore's config.h : [Attachment 39296] New Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Yaar Schnitman
<yaar at chromium.org>'s request for review:
Bug 28882: Merge chromium's config.h.in into WebCore's config.h
https://bugs.webkit.org/show_bug.cgi?id=28882

Attachment 39296: New Patch
https://bugs.webkit.org/attachment.cgi?id=39296&action=review

------- Additional Comments from David Levin <levin at chromium.org>
r- for now to answer questions/concerns below.

> diff --git a/WebCore/config.h b/WebCore/config.h
> + * Copyright (C) 2009, Google Inc. All rights reserved.
No comma after 2009.


> +// WebCore should compile with WTF_CHANGES as WTF does.
> +#define WTF_CHANGES 1

According to this define is only needed for building FastMalloc, so it sounds
like this shouldn't be here.


Consider can/should these items be moved into the gyp file since other defines
were moved there?
   #if !PLATFORM(DARWIN)
   // Define SKIA on non-Mac.
   #define WTF_PLATFORM_SKIA 1
   #endif /* !PLATFORM(DARWIN) */
   #define WTF_USE_GOOGLEURL 1 

   /* Chromium uses V8 by default */
   #if !defined(WTF_USE_V8)
   #define WTF_USE_V8 1
   #endif
 
I don't have a good criteria for deciding what defines should be in each but
would love to hear your ideas on this.