[webkit-reviews] review requested: [Bug 28054] use derefInNotNull function to work around winscw compiler bug regarding template arguments. : [Attachment 39298] fix build break in mac build.

[bugzilla-daemon at webkit.org]

Yongjun Zhang <yongjun.zhang at nokia.com> has asked  for review:
Bug 28054: use derefInNotNull function to work around winscw compiler bug
regarding template arguments.
https://bugs.webkit.org/show_bug.cgi?id=28054

Attachment 39298: fix build break in mac build.
https://bugs.webkit.org/attachment.cgi?id=39298&action=review

------- Additional Comments from Yongjun Zhang <yongjun.zhang at nokia.com>
Thanks a lot for review.

The reason it fails the mac build is JSObjectWrapper::ref() and deref() are
defined as private methods in WebCore/bridge/jni/jni_instance.h.  The new patch
moves them to public to fix the build break.

Is there any reason why ref() and deref() needs to be private in this case?  If
yes, the patch might be wrong and I will figure out a different way to address
this.