[webkit-reviews] review requested: [Bug 27255] Geolocation incorrectly calls error callback in case of exception in success callback : [Attachment 39270] Patch 4 for bug 27255

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 9 08:34:37 PDT 2009


steveblock at google.com has asked  for review:
Bug 27255: Geolocation incorrectly calls error callback in case of exception in
success callback
https://bugs.webkit.org/show_bug.cgi?id=27255

Attachment 39270: Patch 4 for bug 27255
https://bugs.webkit.org/attachment.cgi?id=39270&action=review

------- Additional Comments from steveblock at google.com
> Just noticed that braces should go now that this is only one line.
Fixed

This should be private, not public.
Fixed, and also in JSCustomPositionErrorCallback.h

> The argument name "position" should be omitted.
Fixed

Could you commit on my behalf please - I don't have committer rights?


More information about the webkit-reviews mailing list