[webkit-reviews] review denied: [Bug 29077] [v8] Share persistent context handles between events : [Attachment 39253] initial
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 9 08:33:49 PDT 2009
Adam Barth <abarth at webkit.org> has denied Christian Plesner Hansen
<christian.plesner.hansen at gmail.com>'s request for review:
Bug 29077: [v8] Share persistent context handles between events
https://bugs.webkit.org/show_bug.cgi?id=29077
Attachment 39253: initial
https://bugs.webkit.org/attachment.cgi?id=39253&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
SharedV8Context doesn't really have anything to do with contexts. We should
make it more general (templated?) and put it in its own header, like OwnHandle.
You might want to call it something like RefCountedHandle or something.
Aside from that, this patch looks good.
More information about the webkit-reviews
mailing list