[webkit-reviews] review denied: [Bug 29068] NPAPI Plugin NPP_AsFile not working on Qt Webkit : [Attachment 39247] Patch which solves the deletion of created temp file before passing to plugin in NPP_AsFile

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Rohini Ananth
<rohini.ananth at nokia.com>'s request for review:
Bug 29068: NPAPI Plugin NPP_AsFile not working on Qt Webkit
https://bugs.webkit.org/show_bug.cgi?id=29068

Attachment 39247: Patch which solves the deletion of created temp file before
passing to plugin in NPP_AsFile 
https://bugs.webkit.org/attachment.cgi?id=39247&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Your patch looks good in principle, thanks for tracking down this bug!

> +	QTemporaryFile *tempFile = new QTemporaryFile(QLatin1String(prefix));
> +	tempFile->setAutoRemove(false);
> +	QFile *temp = tempFile;

Please fix the coding style for the newly added lines, the position of the *
should be next to the type, not the variable.

Also please include a ChangeLog entry explaining your fix, using the same (very
good btw) explanation you
mentioned in this bugzilla entry.

r- because of that, but otherwise ok :-)