[webkit-reviews] review requested: [Bug 28806] [Qt] Make the WebInspector available as a widget class. : [Attachment 39254] Changes v0.4

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 28806: [Qt] Make the WebInspector available as a widget class.
https://bugs.webkit.org/show_bug.cgi?id=28806

Attachment 39254: Changes v0.4
https://bugs.webkit.org/attachment.cgi?id=39254&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
(In reply to comment #4)

> Shall we mention it simple "as QWidget" to avoid confusion?
Yes, guess so

> 
> Do we need to add the new friend in this patch? Where is it necessary?
No, not in this patch, removed it

> 
> "value" is a weird argument name.
Changed them

> 
> Just to confirm: although this is a new file, part of it was taken from
another
> code where Holger has his copyright?
Ah, copy/paste error. Except on this copyright line I don't think he needs
copyright.

> 
> Do we need to mention all the new functions? Probably fine with only listing
> the new source files?
Removed

> 
> Final concern: don't we need a unit test (or even a manual test) for this?
I agree, the class is at least used in QtLauncher, but if you think of any
other way to test this, please let me know.