[webkit-reviews] review denied: [Bug 29032] [Qt] locale date displays incorrect date format in symbian : [Attachment 39185] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 8 09:26:35 PDT 2009


Eric Seidel <eric at webkit.org> has denied Pat <vincent.bradley at nokia.com>'s
request for review:
Bug 29032: [Qt] locale date displays incorrect date format in symbian
https://bugs.webkit.org/show_bug.cgi?id=29032

Attachment 39185: Patch
https://bugs.webkit.org/attachment.cgi?id=39185&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Is this covered by an existing layout test?  If so, please update the ChangeLog
to say so.  Otherwise we need to write a new test.

Also, it seems we should update the comment:
     // strftime() we are using does not support #
To say something like:
     // strftime() does not support '#' on WinCE or Symbian.


More information about the webkit-reviews mailing list