[webkit-reviews] review denied: [Bug 28964] [Chromium] ChromiumDataObject should have getter/setter interface : [Attachment 39135] patch: add getter/setter accessor methods
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 8 09:42:12 PDT 2009
Eric Seidel <eric at webkit.org> has denied Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 28964: [Chromium] ChromiumDataObject should have getter/setter interface
https://bugs.webkit.org/show_bug.cgi?id=28964
Attachment 39135: patch: add getter/setter accessor methods
https://bugs.webkit.org/attachment.cgi?id=39135&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
These don't need to be marked inline. Compilers already inline such functions.
If they didn't we'd see duplicated symbol definitions all over the place. :)
I take it that the "chromium code" in question lives outside of the WebKit
tree? So that we have to do this in two-stages like this?
More information about the webkit-reviews
mailing list