[webkit-reviews] review requested: [Bug 28931] [chromium] Linux: Expose functions to set the caret blink interval : [Attachment 39118] fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 5 21:19:44 PDT 2009
Joel Stanley <joel at jms.id.au> has asked for review:
Bug 28931: [chromium] Linux: Expose functions to set the caret blink interval
https://bugs.webkit.org/show_bug.cgi?id=28931
Attachment 39118: fix
https://bugs.webkit.org/attachment.cgi?id=39118&action=review
------- Additional Comments from Joel Stanley <joel at jms.id.au>
I should have implemented caretBlinkInterval instead of
caretBlinkIntervalInternal as blinking wasn't being disabled for the layout
tests (see WebCore/rendering/RenderThemeChromiumSkia.cpp 194).
There was no default value being set, like you asked.
I am using git so this patch might not be formatted the way you need. Is there
an equivalent of svn-create-patch for git?
More information about the webkit-reviews
mailing list