[webkit-reviews] review granted: [Bug 28954] hostname and host are mixed up when manipulating anchor elements : [Attachment 39089] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 28954: hostname and host are mixed up when manipulating anchor elements
https://bugs.webkit.org/show_bug.cgi?id=28954

Attachment 39089: Patch
https://bugs.webkit.org/attachment.cgi?id=39089&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (url.hostEnd() == url.pathStart())

I think it's slightly unclear to code it this way. I'd prefer to have a
hasPort() function on KURL. In fact, at one point these hostEnd() and
pathStart() functions didn't exist, and I'm not sure we'll want to keep them in
the long run.

But I guess this is OK as-is for now. I won't insist on changing KURL.h.

r=me