[webkit-reviews] review denied: [Bug 28682] [Qt] QtWebKit Persistent API : [Attachment 39003] second try
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 4 06:33:16 PDT 2009
Ariya Hidayat <ariya.hidayat at trolltech.com> has denied Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 28682: [Qt] QtWebKit Persistent API
https://bugs.webkit.org/show_bug.cgi?id=28682
Attachment 39003: second try
https://bugs.webkit.org/attachment.cgi?id=39003&action=review
------- Additional Comments from Ariya Hidayat <ariya.hidayat at trolltech.com>
Looks good, except that we need a unit test (no matter how simple it is). It's
a matter of checking all settings before calling enablePersistentStorage, and
then checking everything again after. Sanity checks only, but hey, it's better
to do it than to regret it later :)
r- until the test is added.
More information about the webkit-reviews
mailing list