[webkit-reviews] review denied: [Bug 28907] [Qt] The --strict switch of run-webkit-tests does not work : [Attachment 38924] Add Changelog entry to my without-metrics patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 4 06:27:29 PDT 2009


Ariya Hidayat <ariya.hidayat at trolltech.com> has denied Andras Becsi
<becsi.andras at stud.u-szeged.hu>'s request for review:
Bug 28907: [Qt] The --strict switch of run-webkit-tests does not work
https://bugs.webkit.org/show_bug.cgi?id=28907

Attachment 38924: Add Changelog entry to my without-metrics patch
https://bugs.webkit.org/attachment.cgi?id=38924&action=review

------- Additional Comments from Ariya Hidayat <ariya.hidayat at trolltech.com>
As discussed over IRC, this patch should not remove --strict and it should just
compare between test result and expected of the port (i.e. not mixing it with
Qt vs Mac).

Also, a name like exclude-metrics or skip-metrics sounds like a better name
than without-metrics.

r- until the issue is addressed.


More information about the webkit-reviews mailing list