[webkit-reviews] review denied: [Bug 26584] [Qt] Printing extra information : [Attachment 34390] New patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Jakob Truelsen <antialize at gmail.com>'s
request for review:
Bug 26584: [Qt] Printing extra information
https://bugs.webkit.org/show_bug.cgi?id=26584

Attachment 34390: New patch
https://bugs.webkit.org/attachment.cgi?id=34390&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You ChangeLog entry is malformed.

style:
 1152 quint32 QWebFrame::countPages(QPrinter* printer) const {

c++ code in WebCore uses static_cast<int>:
+		      int(qprinterRect.width() / zoomFactorX),
+		      int(qprinterRect.height() / zoomFactorY));

WebCore style is to omit argument names when they don't add value:
 #ifndef QT_NO_PRINTER
-    void print(QPrinter *printer) const;
+    void print(QPrinter* printer) const;
+    void print(QPrinter* printer, QPainter* painter) const;
 #endif
maye that's not true of qt?

Since no Qt person has made a comment on this in the 20+ days that it has been
up or review, I can only assume they don't want this patch.  I would encourage
you to try and track down a Qt reviewer (ideally over email) and get their
attention before posting the revised version.

r- for the nits above.