[webkit-reviews] review denied: [Bug 25253] REGRESSION: 'maxLength' of input text field doesn't work for CJK characters : [Attachment 38910] Proposed patch (rev.3)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 3 00:52:01 PDT 2009


Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 25253: REGRESSION: 'maxLength' of input text field doesn't work for CJK
characters
https://bugs.webkit.org/show_bug.cgi?id=25253

Attachment 38910: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=38910&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
These tests look like they can be dumpAsText() tests.  That's much preferred
over render tree dump tests.

Why do we need to pass Document* now that we're passing Element*?  you can get
element->document(). :)


More information about the webkit-reviews mailing list