[webkit-reviews] review granted: [Bug 24696] Enable mixed content detection : [Attachment 38352] Step 2: Delegate callbacks and DumpRenderTree changes.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 3 00:46:33 PDT 2009
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 24696: Enable mixed content detection
https://bugs.webkit.org/show_bug.cgi?id=24696
Attachment 38352: Step 2: Delegate callbacks and DumpRenderTree changes.
https://bugs.webkit.org/attachment.cgi?id=38352&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Most roundabout method to print a string, ever:
NSString *string = [NSString
stringWithFormat:@"didDisplayInsecureContent"];
361 printf ("%s\n", [string UTF8String]);
Not only could you have used @"string" to make a literal, or just
printf("mystring\n"). Instead you went for full style points. ;)
In general this looks fine though. So fixing your string printing nit is all i
see. (That said, that one nit makes me question the rest of the mac code. :)
More information about the webkit-reviews
mailing list