[webkit-reviews] review denied: [Bug 24696] Enable mixed content detection : [Attachment 38350] Step 4: Tests!

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 24696: Enable mixed content detection
https://bugs.webkit.org/show_bug.cgi?id=24696

Attachment 38350: Step 4: Tests!
https://bugs.webkit.org/attachment.cgi?id=38350&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems a better testing infrastructure would be if we could query if a certain
callback ever was called instead of dumping every one. :(

Would be helpful to list what the name of the callback is supposed to be:
+This test loads a secure iframe that loads an insecure iframe. We should *not*
trigger a delegate callback because the frame's origin is *not* contaminated.

so that people looking at your test have some prayer of knowing what to look
for. :)

I'm surprised this is not default:
 9     layoutTestController.setCloseRemainingWindowsWhenComplete(true);

I'm surprised boring.html is not just replaced by "about:blank" or a data url?