[webkit-reviews] review canceled: [Bug 28880] svn-apply --force doesn't actually work : [Attachment 38873] Patch 2 v1

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 28880: svn-apply --force doesn't actually work
https://bugs.webkit.org/show_bug.cgi?id=28880

Attachment 38873: Patch 2 v1
https://bugs.webkit.org/attachment.cgi?id=38873&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #6)
> (From update of attachment 38873 [details])
> Would be nice to have unit tests of this. :)	Would be possible with scm.py,
> but also not required.  cq- for ChangeLog diff and because you're a
committer.

I'm clearing the review flag to (1) make --force work as expected from the
command-line so that it applies all of the patches and (2) makes svn-apply exit
with a non-zero status if any forced patches didn't apply cleanly.

That should satisfy both the command-line usage and bugzilla-tool's commit-queu
mode.