[webkit-reviews] review granted: [Bug 28167] WINCE PORT: Implement ImageBuffer : [Attachment 34765] updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 2 08:04:40 PDT 2009


Adam Barth <abarth at webkit.org> has granted  review:
Bug 28167: WINCE PORT: Implement ImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=28167

Attachment 34765: updated
https://bugs.webkit.org/attachment.cgi?id=34765&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Based on the webkit-dev discussion and George's comment above, this patch is
probably fine.	I'm not in love with this code

+ *dst++ = static_cast<unsigned char>((red * alpha + 254) / 255);

but I think it's ok for a first pass.

Thanks for your patience.


More information about the webkit-reviews mailing list