[webkit-reviews] review denied: [Bug 28901] strnstr in wtf/StringExtras.h : [Attachment 38912] Add strnstr for Linux and Windows in StringExtras.h
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 2 00:30:08 PDT 2009
Eric Seidel <eric at webkit.org> has denied Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 28901: strnstr in wtf/StringExtras.h
https://bugs.webkit.org/show_bug.cgi?id=28901
Attachment 38912: Add strnstr for Linux and Windows in StringExtras.h
https://bugs.webkit.org/attachment.cgi?id=38912&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
I would have used longer names for the variables. Just because this is a POSIX
method doesn't mean we have to use old c-style naming conventions. ;)
r-, but not for the naming nit, rather for the nits above from ap. :)
Thanks for the patch!
More information about the webkit-reviews
mailing list