[webkit-reviews] review granted: [Bug 28881] svn-create-patch should check if the repo path is the same when trying to find the root : [Attachment 38881] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 2 00:27:36 PDT 2009
Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 28881: svn-create-patch should check if the repo path is the same when
trying to find the root
https://bugs.webkit.org/show_bug.cgi?id=28881
Attachment 38881: Patch v1
https://bugs.webkit.org/attachment.cgi?id=38881&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good to me. So sad that we don't have unit tests for this sort of thing.
:( It's possible to test this stuff via scm.py for sure. cq- for ChangeLog
patch and because yor'e a committer.
More information about the webkit-reviews
mailing list