[webkit-reviews] review denied: [Bug 27376] [WINCE] Add WinCE specific files for platform/network : [Attachment 33206] The rest of WebCore/platform/network/wince (v2)

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Adam Treat <treat at kde.org>'s request
for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33206: The rest of WebCore/platform/network/wince (v2)
https://bugs.webkit.org/attachment.cgi?id=33206&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+ #ifndef AuthenticationChallenge_h

Missing space before this line.

+ #if PLATFORM(TORCHMOBILE)

Is TORCHMOBILE really a platform?  I would have expected WINCE here.

+ static ThreadData g_threadData = {0};

No real point in declaring this static inside the anonymous namespace...

+ } // namespace WebCore

Missing space before this line.

+ punycode.c

It's unclear to me whether this license is compatible with the BSD license
because the BSD license does diminish someone's ability to distribute: they
must include the license block.  I can't R+ this patch without input from a
lawyer.

Also, this file isn't even close to WebKit style.