[webkit-reviews] review denied: [Bug 27376] [WINCE] Add WinCE specific files for platform/network : [Attachment 33204] Broken out ResourceHandleWince into own patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Adam Treat <treat at kde.org>'s request
for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33204: Broken out ResourceHandleWince into own patch
https://bugs.webkit.org/attachment.cgi?id=33204&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
One class per file, please.

+  static ResourceJobManager jm;

You should use the DEFINE_STATIC_LOCAL macro.

+ ConnectionManager() //, LPCWSTR userAgentTex)

Please don't included commented out code.

+ delete m_connMgr;
delete[] m_formDataString;

Why not OwnPtr and OwnArray?

+ ResourceHandle::setResponse

The fake URL parsing in this function is not cool.  Also, this primitive mime
sniffing is very insecure.

I stopped reviewing this patch at this point.